Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add command args for plugin #2992

Merged
merged 3 commits into from
Aug 30, 2023
Merged

feat: add command args for plugin #2992

merged 3 commits into from
Aug 30, 2023

Conversation

izturn
Copy link
Contributor

@izturn izturn commented Aug 28, 2023 •
edited
Loading

Signed-off-by: Gang Liu [email protected]

fix #2991

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023 •
edited
Loading

Go Published Test Results

2 042 tests   2 042 ✔️  2m 40s ⏱️
   118 suites         0 💤
       1 files           0 ❌

Results for commit 74feaea.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023 •
edited
Loading

E2E Tests Published Test Results

    4 files      4 suites   3h 43m 1s ⏱️
102 tests   82 ✔️   6 💤 14 ❌
426 runs  385 ✔️ 24 💤 17 ❌

For more details on these failures, see this check.

Results for commit 74feaea.

♻️ This comment has been updated with latest results.

@zachaller
Copy link
Collaborator

Can we add some documentation around this here?

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
41.9% 41.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@izturn
Copy link
Contributor Author

izturn commented Aug 30, 2023

@zachaller done PTAL

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (75bade5) 81.75% compared to head (74feaea) 81.75%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2992   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         134      134           
  Lines       20377    20377           
=======================================
  Hits        16659    16659           
  Misses       2861     2861           
  Partials      857      857
Files Changed Coverage Δ
utils/plugin/plugin.go 47.05% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaller zachaller merged commit d4c7728 into argoproj:master Aug 30, 2023
20 of 22 checks passed
@tommy351 tommy351 mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable set the command arguments for plugin
2 participants
@izturn @zachaller